Skip to content

Conversation

@lucas-watkins
Copy link
Contributor

Try to close #406

@AndreiKingsley AndreiKingsley changed the base branch from main to dev September 3, 2024 20:36
@AndreiKingsley
Copy link
Collaborator

Looks like Inset class is a basically the same as Margin. So, may be we don't need another class here, only property/function names.

@AndreiKingsley AndreiKingsley self-requested a review September 3, 2024 20:39
}
}

public data class Inset(val top: Double, val right: Double, val bottom: Double, val left: Double) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the same as Margin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do, would a typealias be acceptable here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

@AndreiKingsley AndreiKingsley merged commit aaf638e into Kotlin:dev Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add plotInset parameter to style

2 participants