Skip to content

Use lower case letters for hex-formatted ByteStrings #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Use lower case letters for hex-formatted ByteStrings #160

merged 1 commit into from
Jun 30, 2023

Conversation

@fzhinkin
Copy link
Collaborator

@fzhinkin fzhinkin commented Jun 30, 2023

Buffer's use lower-case characters, stdlib's HexFormat use lower-case characters by default too.

Fixed case of the characters appearing in ByteString::toString for consistency.

@fzhinkin fzhinkin requested a review from shanshin June 30, 2023 09:43
@fzhinkin fzhinkin merged commit bd5ba55 into develop Jun 30, 2023
@fzhinkin fzhinkin deleted the bytestring-hex-use-lower-case branch June 30, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shanshin shanshin shanshin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fzhinkin @shanshin