Add calls-in-place contracts to unsafe operations #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
commented
Aug 2, 2024
Comment on lines
+721
to
+723
| if (this.head == null) { | ||
| return lambda(null, -1L) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This seems like it was a bug. Prior to this, the lambda would be called twice. Once with (null, -1) and then again in the if with (null, 0). Contract validation failed without changing the implementation to early-return here, as I expect was intended.
Collaborator
There was a problem hiding this comment.
It was a bug, indeed. Thanks for catching and fixing it!
fzhinkin
requested changes
Aug 12, 2024
fzhinkin
approved these changes
Aug 15, 2024
Collaborator
fzhinkin
left a comment
fzhinkin
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix, @JakeWharton!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #361