grpc: Status exception API refactoring #536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mr3zee
approved these changes
Nov 24, 2025
| */ | ||
| public val Status.description: String? get() = getDescription() | ||
|
|
||
| // this is currently @InternalRpcApi as it's behavior would be inconsistent between JVM and Native. |
Collaborator
Author
There was a problem hiding this comment.
Some APIs in Java attach the causing exception. However, on native, we would lose the causing exception information as we can't pass it through the C layer. So I think it might be better to just omit it, so users don't rely on the cause value of the Status exception.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
gRPC
Problem Description
The current
StatusExceptionAPI is far from Kotlin idiomatic.Solution
Because
StatusExceptionis tightly coupled with the JavaStatusExceptionas it is just a typealias, we have some constraints in regard to changes of the implementation.This PR tries to address the most inconvenient parts of the current API by using extension functions:
StatusException.statusStatusException.trailersStatus.descriptionStatus.statusCodeStatusCode.asExceptionStatusCode.asStatusStatus.asException