[RomApp] Adding candidate elements (and/or conditions) to HROM #11577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SADPR
reviewed
Sep 20, 2023
| "include_nodal_neighbouring_elements_model_parts_list":[], | ||
| "include_minimum_condition": false, | ||
| "include_condition_parents": true | ||
| "include_condition_parents": false |
There was a problem hiding this comment.
In the worst case, it won't use the info of the parent element. Still, it is generally more likely to fail because we need an associated parent element (e.g. Convection-Diffusion, Fluid-Dynamics, CompressiblePotenital).
|
Tested (evidence): ECM passing the list of candidates (right wall): |
Comment on lines
+407
to
+427
| std::vector<IndexType> RomAuxiliaryUtilities::GetElementIdsInModelPart( | ||
| const ModelPart& rModelPart) | ||
| { | ||
| std::vector<IndexType> element_ids; | ||
|
|
||
| for (const auto& r_elem : rModelPart.Elements()) { | ||
| element_ids.push_back(r_elem.Id()); | ||
| } | ||
| return element_ids; | ||
| } | ||
|
|
||
| std::vector<IndexType> RomAuxiliaryUtilities::GetConditionIdsInModelPart( | ||
| const ModelPart& rModelPart) | ||
| { | ||
| std::vector<IndexType> condition_ids; | ||
|
|
||
| for (const auto& r_cond : rModelPart.Conditions()) { | ||
| condition_ids.push_back(r_cond.Id()); | ||
| } | ||
| return condition_ids; | ||
| } |
There was a problem hiding this comment.
Just pointing that these two can be easily done in parallel with an index partition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR will allow to make the element selector algorithm choose from a specific candidate set of elements or conditions. In case choosing the provided candidates the algorithm cannot converge, then the candidate set is expanded to include the rest of the elements and conditions in the computing model part.
It is also possible that by using the provided candidate elements, no solution can be achived that results in all weights positive. In such a case, the algorithm will run again from scratch (ignoring the provided candidates).
🆕 Changelog