[RomApp] Fixing bug in ECM #11611
Merged
[RomApp] Fixing bug in ECM #11611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
any simulation containing more than k elements was going to fail even if it was converging
Rbravo555
added
FastPR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug found in the Empirical Cubature Method which was introduced in a recent addition (#11577)
📝 Description
An iteration counter inside the ECM was used to monitor whether the initial candidate set is not converging. However this was done incorrectly. The idea was that after a "large" number of unsuccessful iterations (this is still hard-coded to 1000), the algorithm should be considered not succesful. The counter now works correctly
Another change was performed to the RomManager in case a candidate set was passed and, it was not successful. Then the algorithm should be invoked again without any candidate set. This was done incorrectly in the RomManger due to a typo.
🆕 Changelog