Skip to content

Conversation

@junkpiano
Copy link
Contributor

@junkpiano junkpiano commented Jul 15, 2018

Currently, Xcode beta versions are not annotated, when you call xcversion list.
This fix should be applicable for ancient Xcode versions as well, such as "4.3.1 for Lion", although nobody would use them now.

before
screen shot 2018-07-16 at 1 11 26
after
screen shot 2018-07-16 at 1 12 02

This is reported in the comment of #291 .

Copy link
Member

@KrauseFx KrauseFx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, and thanks for adding tests 😍

@KrauseFx KrauseFx merged commit e105d55 into xcpretty:master Jul 16, 2018
@junkpiano junkpiano deleted the refactor/add-annotation-to-beta branch July 17, 2018 03:33
@junkpiano
Copy link
Contributor Author

Awesome. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants