-
-
Notifications
You must be signed in to change notification settings - Fork 0
refactor(ci): extract common CI setup to composite action #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Extract Node.js, pnpm, just setup to `.github/actions/setup-env` - Remove duplicated setup steps from test, e2e-ui-test, e2e-report-merge jobs - Add optional turbo cache with configurable suffix fix #200
Summary of ChangesHello @KubrickCode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the Continuous Integration (CI) workflow by extracting common environment setup steps into a reusable composite GitHub Action. This change aims to reduce redundancy across different CI jobs, such as test and e2e runs, by providing a single, centralized point for configuring Node.js, pnpm, and Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request is a great refactoring that extracts common CI setup steps into a reusable composite action, improving maintainability. The new action correctly sets up Node.js, pnpm, and just, and includes an optional step for caching with Turborepo. My review includes a critical fix for an invalid action version that would cause CI failures, along with some medium-severity suggestions to enhance the stability and maintainability of the new action by pinning action versions and managing the Node.js version more effectively.
.github/actions/setup-envfix #200