-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix formatting inconsistency between save and lint execution #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @KubrickCode, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a formatting inconsistency issue where the VS Code extension and CLI were using different versions of Prettier, leading to divergent code styles. The solution involves standardizing on a single, locally managed Prettier version by adding it as a Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
VS Code Extension used bundled Prettier while CLI used global Prettier, causing formatting differences due to version mismatch. Added local prettier as devDependency to ensure all tools use the same version (3.6.2).
a92dd14 to
31bd41f
Compare
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively resolves the formatting inconsistencies by making Prettier a local development dependency, ensuring all developers and tools use the same version. The changes to remove the global installation and update the scripts to use the local version via npx are correct and well-executed. I've included a couple of suggestions to further improve code maintainability and script efficiency in justfile and .devcontainer/post-create.sh.
Fix formatting inconsistency between save and lint execution
VS Code Extension used bundled Prettier while CLI used global Prettier, causing formatting differences due to version mismatch. Added local prettier as devDependency to ensure all tools use the same version (3.6.2).