Skip to content

Conversation

@SkepticRaven
Copy link
Contributor

Bug patches:

  • Some pose masking did not properly threshold confidences
  • Masking of keypoints not tiled correctly to x,y locations
  • Pixel units never applied properly to some features
  • FPS feature not applied to some segmentation features
  • Adjusted angle features to be "mathematicians" angle (0 heading forward, + counter-clockwise)

Internal Change

  • To avoid future confusion, all data is now represented internally as (x, y). Data is transformed at pose file read time. Cached data is always (x,y). Handful of incorrect comments were corrected/removed. Features were adjusted to remain correct.

@SkepticRaven SkepticRaven added the bug Something isn't working label Sep 9, 2024
@SkepticRaven SkepticRaven requested a review from dahhei September 9, 2024 13:48
@SkepticRaven SkepticRaven linked an issue Sep 9, 2024 that may be closed by this pull request

from .pose_est_v4 import PoseEstimationV4

OBJECTS_STORED_YX = [
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good note to have

@dahhei
Copy link

dahhei commented Sep 17, 2024

Most of what I saw was you swapping around x and y values when necessary, and adjusting the masking functions to work with a new minimum_confidence. This all looked good to me, documentation also looks good (doesn't look like you really added new functions that would need new docstrings). I didn't test any of the actual functionality, I can try if you want me to, but I assume we'd find out if anything errors pretty quickly and I'd probably not be a great tester for each individual change.

All in all, I have no issues and think this can be merged.

@SkepticRaven SkepticRaven merged commit 8014b4b into main Sep 17, 2024
@SkepticRaven SkepticRaven deleted the fix-keypoint-masking branch September 17, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pixels -> cm conversion not being used in features

3 participants