Skip to content

Conversation

@zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #115

2. What is the scope of this PR (e.g. component or file name):

compiler_base/error/emitter.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

deleted method apply_style(), Style provides method render_style_to_color_spec() to replace it.
Adapted trait Emitter for Diagnostic and StyledBuffer.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added enhancement New feature or request error-handling Issues or PRs related to kcl error handling feat labels Aug 16, 2022
@zong-zhe zong-zhe added this to the v0.4.3 Release milestone Aug 16, 2022
@zong-zhe zong-zhe requested review from He1pa, Peefy, chai2010 and ldxdl August 16, 2022 02:08
@zong-zhe zong-zhe self-assigned this Aug 16, 2022
@coveralls
Copy link
Collaborator

coveralls commented Aug 16, 2022

Pull Request Test Coverage Report for Build 2908528634

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.185%

Totals Coverage Status
Change from base Build 2908486099: 0.0%
Covered Lines: 21457
Relevant Lines: 36254

💛 - Coveralls

Peefy
Peefy previously approved these changes Aug 16, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suqash your commit

Peefy
Peefy previously approved these changes Aug 23, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@He1pa
Copy link
Contributor

He1pa commented Aug 23, 2022

LGTM

Copy link
Contributor

@He1pa He1pa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zong-zhe zong-zhe merged commit 12a45a7 into kcl-lang:main Aug 23, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2022
@zong-zhe zong-zhe deleted the reuse-kclvm-emitter branch September 1, 2022 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request error-handling Issues or PRs related to kcl error handling feat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants