Skip to content

Conversation

@NeverRaR
Copy link
Contributor

@NeverRaR NeverRaR commented Aug 30, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/capi/

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
    support kclvm cli capi call

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

kclvm/capi/src/api_test.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@coveralls
Copy link
Collaborator

coveralls commented Aug 30, 2022

Pull Request Test Coverage Report for Build 2955658309

  • 179 of 231 (77.49%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 59.869%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/capi/src/service/service.rs 49 60 81.67%
kclvm/capi/src/service/util.rs 8 22 36.36%
kclvm/capi/src/service/api.rs 55 82 67.07%
Files with Coverage Reduction New Missed Lines %
kclvm/compiler/src/codegen/llvm/node.rs 2 89.54%
Totals Coverage Status
Change from base Build 2949877482: -0.3%
Covered Lines: 22555
Relevant Lines: 37674

💛 - Coveralls

@Peefy Peefy added the api Issues or PRs related to kcl rust native APIs and multi-lang APIs label Aug 30, 2022
@Peefy Peefy added this to the v0.4.3 Release milestone Aug 30, 2022
@NeverRaR NeverRaR force-pushed the kclvm-capi-call branch 2 times, most recently from 29432b0 to c6bbf96 Compare August 30, 2022 10:52
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 29245f6 into kcl-lang:main Aug 31, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api Issues or PRs related to kcl rust native APIs and multi-lang APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants