Skip to content

Conversation

NeverRaR
Copy link
Contributor

@NeverRaR NeverRaR commented Oct 26, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

/kclvm/runtime

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@NeverRaR NeverRaR added runtime Issues or PRs related to kcl runtime including value and value opertions refactor labels Oct 26, 2022
@coveralls
Copy link
Collaborator

coveralls commented Oct 26, 2022

Pull Request Test Coverage Report for Build 3334471895

  • 114 of 269 (42.38%) changed or added relevant lines in 23 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-29.5%) to 59.975%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/value/val_union.rs 0 1 0.0%
kclvm/runtime/src/context/mod.rs 0 2 0.0%
kclvm/runtime/src/value/val_from.rs 6 8 75.0%
kclvm/runtime/src/value/val_json.rs 1 3 33.33%
kclvm/runtime/src/value/val_clone.rs 3 6 50.0%
kclvm/runtime/src/value/val_list.rs 0 3 0.0%
kclvm/runtime/src/value/val_type.rs 7 10 70.0%
kclvm/runtime/src/value/val_dict.rs 4 8 50.0%
kclvm/runtime/src/stdlib/builtin_api.rs 0 6 0.0%
kclvm/runtime/src/stdlib/builtin.rs 1 9 11.11%
Totals Coverage Status
Change from base Build 3334066564: -29.5%
Covered Lines: 21772
Relevant Lines: 36302

💛 - Coveralls

@NeverRaR NeverRaR force-pushed the dev/boying/runtime/clippy branch 2 times, most recently from 7cae524 to 556e1fb Compare October 26, 2022 12:27
@NeverRaR NeverRaR changed the title [WIP] Refactor: remove cargo clippy errors & warnings from runtime Refactor: remove cargo clippy errors & warnings from runtime Oct 26, 2022
@NeverRaR NeverRaR force-pushed the dev/boying/runtime/clippy branch 3 times, most recently from 2f85976 to 27e95e9 Compare October 27, 2022 03:10
@NeverRaR NeverRaR force-pushed the dev/boying/runtime/clippy branch from 27e95e9 to c39baed Compare October 27, 2022 04:21
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeverRaR NeverRaR requested a review from chai2010 October 27, 2022 05:30
@Peefy Peefy added this to the v0.4.4 Release milestone Oct 27, 2022
@NeverRaR NeverRaR requested review from He1pa and zong-zhe October 27, 2022 08:27
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chai2010 chai2010 merged commit 2959223 into kcl-lang:main Oct 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refactor runtime Issues or PRs related to kcl runtime including value and value opertions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants