-
Notifications
You must be signed in to change notification settings - Fork 153
refactor: compiling kcl code to object file instead of dylib and packaging LLVM lld library statically into kclvm binary. #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Pull Request Test Coverage Report for Build 3407067403
💛 - Coveralls |
45001d6 to
0dab97a
Compare
046a10a to
ed055db
Compare
ed055db to
646c5d7
Compare
ldxdl
reviewed
Nov 4, 2022
ldxdl
reviewed
Nov 4, 2022
ldxdl
reviewed
Nov 4, 2022
ldxdl
reviewed
Nov 4, 2022
646c5d7 to
7d26129
Compare
Contributor
|
lgtm |
ldxdl
previously approved these changes
Nov 5, 2022
… ld library statically packaged in kclvm.
7d26129 to
2a2fc7c
Compare
zong-zhe
approved these changes
Nov 7, 2022
Contributor
zong-zhe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ldxdl
approved these changes
Nov 7, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
re #53.
In order to better package KCLVM and reduce the probability of errors in the user's local kcl binary, the llvm library is statically packaged into the kcl binary to avoid using the user's local clang for assembling and linking. The goal is to solve the instability problem when KCL uses the user's clang/ld for code linking (mainly due to different versions of built-in cc on different OS).
Besides, after solving this problem, it is necessary to further move the python3 included in the KCLM from the KCLVM installation package to the outside to reduce the final KCLVM installation package size. cc @chai2010
Design
The previous compilation process is:

After the issue is completed, the KCLVM binary package only contains the following contents (Take the macos target as an example, and the size is ~80M-90M):
kc runorkpm runlater.)Note:
2. What is the scope of this PR (e.g. component or file name):
kclvm_compilercrate.kclvm_runnercrate.3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.