Skip to content

Conversation

@NeverRaR
Copy link
Contributor

@NeverRaR NeverRaR commented Nov 8, 2022

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

/kclvm/runtime

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

fix : panic caused by byduplicated keys in schema

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The test cases in test/grammar/schema/duplicated_key are used to test whether duplicated keys in schema will cause panic

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@NeverRaR NeverRaR requested review from Peefy, chai2010 and ldxdl November 8, 2022 03:37
@coveralls
Copy link
Collaborator

coveralls commented Nov 8, 2022

Pull Request Test Coverage Report for Build 3416182728

  • 30 of 49 (61.22%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-30.7%) to 59.061%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/runtime/src/crypto/crypto.rs 0 1 0.0%
kclvm/runtime/src/units/units.rs 0 1 0.0%
kclvm/runtime/src/context/mod.rs 0 2 0.0%
kclvm/runtime/src/value/val_bin_aug.rs 3 5 60.0%
kclvm/runtime/src/value/val_type.rs 0 3 0.0%
kclvm/runtime/src/value/api.rs 0 5 0.0%
kclvm/runtime/src/value/val_union.rs 22 27 81.48%
Totals Coverage Status
Change from base Build 3410446908: -30.7%
Covered Lines: 19737
Relevant Lines: 33418

💛 - Coveralls

@NeverRaR NeverRaR force-pushed the dev/boying/runtime/union branch from 8d09758 to bca1b72 Compare November 8, 2022 03:43
@NeverRaR NeverRaR force-pushed the dev/boying/runtime/union branch from bca1b72 to ad5f074 Compare November 8, 2022 03:45
@NeverRaR NeverRaR changed the title fix : panic caused by byduplicated keys in schema fix : panic caused by duplicated keys in schema Nov 8, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy added the runtime Issues or PRs related to kcl runtime including value and value opertions label Nov 8, 2022
@Peefy Peefy added this to the v0.4.4 Release milestone Nov 8, 2022
Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeverRaR NeverRaR merged commit 3698809 into kcl-lang:main Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

runtime Issues or PRs related to kcl runtime including value and value opertions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants