Skip to content

Conversation

chai2010
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@chai2010 chai2010 requested a review from Peefy November 10, 2022 12:35
@coveralls
Copy link
Collaborator

coveralls commented Nov 10, 2022

Pull Request Test Coverage Report for Build 3497354029

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 89.712%

Totals Coverage Status
Change from base Build 3494460464: 0.0%
Covered Lines: 1369
Relevant Lines: 1526

💛 - Coveralls

@Peefy Peefy added this to the v0.4.4 Release milestone Nov 10, 2022
fi

# check python3 version
$python3_bin -c "import sys; sys.exit(0) if sys.version_info>=(3,7,0) else (print('please install python 3.7+') or sys.exit(1))"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.7.3+

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

# libkclvm_cli

# Darwin dylib
if [ -e $topdir/kclvm/target/release/libkclvm_cli_cdylib.dylib ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why change here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes reverted


# Darwin dylib
if [ -e $topdir/kclvm/target/release/libkclvm_cli_cdylib.dylib ]; then
if [ -e target/release/libkclvm_cli_cdylib.dylib ]; then
Copy link
Contributor

@Peefy Peefy Nov 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that the copy of the library related to "Rust" can be placed in kclvm/build.rs. The conditional compilation feature can be used to avoid repeated copying.

Copy link
Contributor

@Peefy Peefy Nov 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, we can consider the complete installation of python3 -m pip install kclvm (including kclvm rust core libs e.g., libkclvm.dylib).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that the copy of the library related to "Rust" can be placed in kclvm/build.rs. The conditional compilation feature can be used to avoid repeated copying.

add todo comment

@Peefy Peefy changed the title feat: reduce binaries size, remove internal python [WIP] feat: reduce binaries size, remove internal python Nov 18, 2022
@Peefy Peefy changed the title [WIP] feat: reduce binaries size, remove internal python feat: reduce binaries size, remove internal python Nov 18, 2022
@Peefy
Copy link
Contributor

Peefy commented Nov 21, 2022

@DataClass in python3.10 and python3.11+ will raise an ValueError: mutable default <class 'xxx'> for field yyy is not allowed: use default_factory. Need to be fixed separately.

@Peefy Peefy closed this Nov 22, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants