-
Notifications
You must be signed in to change notification settings - Fork 151
feat: reduce binaries size, remove internal python #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 3497354029
💛 - Coveralls |
internal/kclvm_py/scripts/cli/kcl
Outdated
fi | ||
|
||
# check python3 version | ||
$python3_bin -c "import sys; sys.exit(0) if sys.version_info>=(3,7,0) else (print('please install python 3.7+') or sys.exit(1))" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.7.3+
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
# libkclvm_cli | ||
|
||
# Darwin dylib | ||
if [ -e $topdir/kclvm/target/release/libkclvm_cli_cdylib.dylib ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why change here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes reverted
|
||
# Darwin dylib | ||
if [ -e $topdir/kclvm/target/release/libkclvm_cli_cdylib.dylib ]; then | ||
if [ -e target/release/libkclvm_cli_cdylib.dylib ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that the copy of the library related to "Rust" can be placed in kclvm/build.rs
. The conditional compilation feature can be used to avoid repeated copying.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition, we can consider the complete installation of python3 -m pip install kclvm
(including kclvm rust core libs e.g., libkclvm.dylib).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that the copy of the library related to "Rust" can be placed in
kclvm/build.rs
. The conditional compilation feature can be used to avoid repeated copying.
add todo comment
@DataClass in python3.10 and python3.11+ will raise an |
1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):
2. What is the scope of this PR (e.g. component or file name):
3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):
4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):
5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:
6. Release note
Please refer to Release Notes Language Style Guide to write a quality release note.