Skip to content

Conversation

@zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #351 .

2. What is the scope of this PR (e.g. component or file name):

compiler_base_error.

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

Added ColoredRaw and UnColoredRaw in compiler_base_error::emitter::Destination to redirection.
Added a method emit_diagnostic_to_uncolored_text to redirect diagnostic emit information to uncolored string.
Rename TerminalEmitter to EmitterWriter.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added this to the v0.4.5 Release milestone Dec 26, 2022
@zong-zhe zong-zhe self-assigned this Dec 26, 2022
@coveralls
Copy link
Collaborator

coveralls commented Dec 26, 2022

Pull Request Test Coverage Report for Build 3890754501

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-28.4%) to 61.324%

Totals Coverage Status
Change from base Build 3884055252: -28.4%
Covered Lines: 20896
Relevant Lines: 34075

💛 - Coveralls

Peefy
Peefy previously approved these changes Dec 26, 2022
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Peefy
Peefy previously approved these changes Jan 9, 2023
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amyXia1994
amyXia1994 previously approved these changes Jan 11, 2023
@amyXia1994 amyXia1994 merged commit b455d43 into kcl-lang:main Jan 13, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants