Skip to content

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Jan 5, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fix: #336 config entry identifier key type infer.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other
  • test/grammar/types/literal/lit_06_entry_id_key/main.k

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added bug Something isn't working resolver labels Jan 5, 2023
@Peefy Peefy added this to the v0.4.5 Release milestone Jan 5, 2023
@Peefy Peefy self-assigned this Jan 5, 2023
@coveralls
Copy link
Collaborator

coveralls commented Jan 5, 2023

Pull Request Test Coverage Report for Build 3845391390

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-28.2%) to 61.554%

Totals Coverage Status
Change from base Build 3827933002: -28.2%
Covered Lines: 22000
Relevant Lines: 35741

💛 - Coveralls

Copy link
Contributor

@NeverRaR NeverRaR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chai2010 chai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 6d60983 into kcl-lang:main Jan 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2023
@Peefy Peefy deleted the fix-config-entry-id-key-ty-infer branch January 16, 2023 12:56
@Peefy Peefy restored the fix-config-entry-id-key-ty-infer branch January 16, 2023 12:56
@Peefy Peefy deleted the fix-config-entry-id-key-ty-infer branch January 16, 2023 12:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working resolver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] The config entry identifier key is deduced as str type instead of string literal type

4 participants