Skip to content

Conversation

Peefy
Copy link
Contributor

@Peefy Peefy commented Mar 9, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re: #420. refactor: use compiler base session in resolver and remove un-used code in the kclvm error crate to prepare for the parser error recovery.

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

All kclvm sema unit tests and grammar tests.

  • kclvm/sema/src/resolver/tests.rs

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@Peefy Peefy added error-handling Issues or PRs related to kcl error handling refactor resolver labels Mar 9, 2023
@Peefy Peefy added this to the v0.4.6 Release milestone Mar 9, 2023
@Peefy Peefy self-assigned this Mar 9, 2023
@coveralls
Copy link
Collaborator

coveralls commented Mar 9, 2023

Pull Request Test Coverage Report for Build 4381194373

  • 67 of 194 (34.54%) changed or added relevant lines in 10 files are covered.
  • 37 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-26.6%) to 63.761%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/cmd/src/lint.rs 0 1 0.0%
kclvm/tools/src/lint/mod.rs 1 4 25.0%
kclvm/sema/src/pre_process/identifier.rs 0 4 0.0%
kclvm/error/src/lib.rs 22 141 15.6%
Files with Coverage Reduction New Missed Lines %
compiler_base/session/src/lib.rs 37 33.93%
Totals Coverage Status
Change from base Build 4363302379: -26.6%
Covered Lines: 21377
Relevant Lines: 33527

💛 - Coveralls

@Peefy Peefy force-pushed the compiler-base-session-in-resolver branch from 26bac5c to 9c189c9 Compare March 9, 2023 13:32
Copy link
Contributor

@zong-zhe zong-zhe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit fb2beed into kcl-lang:main Mar 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

error-handling Issues or PRs related to kcl error handling refactor resolver

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants