Skip to content

Conversation

@zong-zhe
Copy link
Contributor

@zong-zhe zong-zhe commented Apr 7, 2023

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #491

2. What is the scope of this PR (e.g. component or file name):

kclvm_cli

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

add sub commands '-E, --external' for 'kclvm_cli run' to specify the external package path.

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

6. Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@zong-zhe zong-zhe added the enhancement New feature or request label Apr 7, 2023
@zong-zhe zong-zhe added this to the v0.4.6 Release milestone Apr 7, 2023
@zong-zhe zong-zhe self-assigned this Apr 7, 2023
@coveralls
Copy link
Collaborator

coveralls commented Apr 7, 2023

Pull Request Test Coverage Report for Build 4655948998

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.988%

Totals Coverage Status
Change from base Build 4655096333: 0.0%
Covered Lines: 2300
Relevant Lines: 2614

💛 - Coveralls

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging #490, rebase the main branch and move hashmaps_from_matches to the cmd::util module

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit deba5e9 into kcl-lang:main Apr 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants