Skip to content

simplify tags #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 23, 2025
Merged

simplify tags #126

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
be8edaa
simplify tags
tomeichlersmith May 20, 2025
78977aa
fix tabbing
tomeichlersmith May 23, 2025
0807182
share outputs rather than re-run docker-metadata-action
tomeichlersmith May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 5 additions & 20 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,8 @@ jobs:
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern=v{{version}}
type=semver,pattern=v{{major}}.{{minor}}
type=sha,format=short
-
name: Set up QEMU
uses: docker/setup-qemu-action@v3
Expand Down Expand Up @@ -94,6 +92,8 @@ jobs:
runs-on: ubuntu-latest
needs:
- build
outputs:
imagejson: ${{ steps.meta.outputs.json }}
steps:
-
name: Download digests
Expand All @@ -114,10 +114,8 @@ jobs:
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern=v{{version}}
type=semver,pattern=v{{major}}.{{minor}}
type=sha,format=short
-
name: Login to Docker Hub
uses: docker/login-action@v3
Expand Down Expand Up @@ -160,24 +158,11 @@ jobs:
-
name: Download Build Context for Test Script
uses: actions/checkout@v4
-
name: Docker meta
id: meta
uses: docker/metadata-action@v5
with:
images: ${{ env.REGISTRY_IMAGE }}
tags: |
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
type=semver,pattern={{major}}.{{minor}}
type=semver,pattern=v{{version}}
type=semver,pattern=v{{major}}.{{minor}}
-
name: Install just
uses: extractions/setup-just@v3
with:
just-version: 1.26.0
-
name: Test the Image
run: ./ci/test-ldmx-sw $(jq -r .tags[0] <<< "${DOCKER_METADATA_OUTPUT_JSON}") ${{ matrix.ldmx_sw }}
run: ./ci/test-ldmx-sw $(echo '${{ needs.merge.outputs.imagejson }}' | jq -r .tags[0]) ${{ matrix.ldmx_sw }}