bump Geant4 patch version #93
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This small patch to Geant4 is helpful for biased production of samples in volumes upstream of the target and does not affect any of our current samples focused on production (biased or not) within the target or downstream volumes.
tomeichlersmith
commented
Feb 16, 2024
There was a problem hiding this comment.
Evidence for this patch version of G4 not affecting our normal distributions is documented in the PR introducing this change: LDMX-Software/geant4#14
This PR also has additional context and links to other issues with more notes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This small patch to Geant4 is helpful for biased production of samples in volumes upstream of the target and does not affect any of our current samples focused on production (biased or not) within the target or downstream volumes.
I expect the ldmx-sw tests to fail since UMN IT still hasn't resolved the issue with Jeremy's public site hosted there. I will manually check that those tests are the only tests apart of
ctestthat fail.