fix/v7: Remove preinstall script to avoid local build when installing as a dependency #664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ring package installation
Ansonhkg
added
the
🚧 In Progress - Don’t Merge
…s instead of removing them for better debugging purposes.
…y-v7-alpha-isnt-installing
Ansonhkg
added
v7 | Datil
and removed
🚧 In Progress - Don’t Merge
Ansonhkg
deleted the
feature/lit-3913-js-sdk-investigate-why-v7-alpha-isnt-installing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Remove
preinstallThis PR removes the
preinstallscript frompackage.jsoninwasmpackage to prevent the unnecessary execution of the Rust build process (yarn rust:build) during package installation. Since the package is already built and published to npm, running the build step during installation is redundant and causes issues for users installing the package as a dependency.2. Fix postbuild script
Additionally, this PR also fixed & enhanced the
copyWasmBinary.mjspostbuild script, where it removes the module import from the generated code since we encoded the entire binary. If no replacements were made, it will throw an error so that we know we probably need to fix this script.