fix: connection is undefined when connecting to LitContracts
#667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d properties of undefined (reading 'connection')
at _LitContracts.connect (chunk-TOQGCBZM.js?v=866a89b4:58004:52)
at signAndCombineEcdsa (lit.ts:44:22)
at async handleSignAndCombine (App.tsx:6:22)
FedericoAmura
approved these changes
Oct 3, 2024
joshLong145
reviewed
Oct 3, 2024
joshLong145
reviewed
Oct 3, 2024
|
|
||
| this.log('Your Signer:', this.signer); | ||
| this.log('Your Provider:', this.provider.connection); | ||
| this.log('Your Provider:', this.provider?.connection!); |
There was a problem hiding this comment.
should we move this log under the check for this.provider being defined.
Collaborator
Author
There was a problem hiding this comment.
You mean wrap it inside a if/else to check if 'connection' exists then print it out? If so, I don't think so, cus I'd like to see it connection is undefined in different environments when debug is on
There was a problem hiding this comment.
I see, if we want to log out when this.provider is undefined then we can keep it.
joshLong145
approved these changes
Oct 3, 2024
Ansonhkg
deleted the
feature/drel-294-cant-connect-litcontracts-client-using-sdk-v670
branch
This was referenced Oct 3, 2024
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix for this: (Unable to connect using the LitContracts client)
Due to this was added in the PR:
https://github.com/LIT-Protocol/js-sdk/pull/639/files#diff-2dcc2c94e7788b1bbaef5e6cf9158025a2580d238f807bd3cb923bbe355eb47bR401-R406
And we need this patch for the following affected versions:
Anything <= 6.5.3 are working