Get latest commit hash for shiva in CI #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilant? the build issue seems to be related to conflicting nx versions
…:LIT-Protocol/js-sdk into feature/get-latest-commit-hash-for-shiva
Ansonhkg
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now we have a hardcoded lit actions commit hash. This will try to pull down the latest and use that, instead. Github artifacts expire 30 days after publishing so this is prob why CI broke.
This is an extension of #736 where I debugged the underlying issue (well, multiple issues) and found that the commit hash was the first broken thing (because the artifact gets deleted after 30 days), and then we needed to change the
rust/lit-node-build-commit-hashubuntu version to 22, which finally fixed it.This uses our own fork of an action that will pull the latest hash from the lit-assets repo, which is here: https://github.com/LIT-Protocol/last-successful-build-action