Feature/lit 4086 hide sessionsigs #752
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings the
authContextproperty inPKP*Walletinstances down toLitNodeClientto allow for automatic management ofsessionSigsinside its methodsThe
authContextcan be configured/updated when creating theLitNodeClientinstance or afterwards. Having it, it is not needed to passsessionSigsand the instance will use that to create them if needed. When asessionSigsinstance is passed, that will take precedenceThere is also an option to override specific properties of the configured
authContextwhensessionSigsare needed.With this PR, when using the
authContext,litNodeClient.pkpSignandlitNodeClient.executeJscan be executed without receivingsessionSigsType of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
PKPEthersWallet,LitNodeClientwithsessionSigsandLitNodeClientwithauthContextChecklist: