feat(pricing): add sign-session-key pricing support and product-awa…
#925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re sorting - request `SIGN_SESSION_KEY` prices when fetching node data so the contract returns all four product columns - extend pricing context schema to accept `SIGN_SESSION_KEY` and re-sort nodes per product before slicing to threshold - route PKP auth through `SIGN_SESSION_KEY` pricing while keeping custom auth on `LIT_ACTION` - cover the new sort logic with a unit test to prove we now pick the cheapest validators for the requested product
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the SIGN_SESSION_KEY product in the pricing system. It enables the system to capture pricing data for all four endpoint types from contracts and ensures proper node selection based on product-specific pricing.
Key changes:
- Extended pricing schema to include
SIGN_SESSION_KEYproduct type - Modified node selection logic to sort validators by the requested product column rather than defaulting to decryption pricing
- Routed PKP auth adapter through
SIGN_SESSION_KEYpricing path while maintaining custom auth adapter onLIT_ACTION
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| schema.ts | Added SIGN_SESSION_KEY to the pricing context schema enum |
| getMaxPricesForNodeProduct.ts | Enhanced node selection to sort by product-specific pricing column |
| getMaxPricesForNodeProduct.spec.ts | Added comprehensive test validating product-specific node selection behavior |
| getNodesForRequest.ts | Added SIGN_SESSION_KEY product ID constant and documentation |
| getPkpAuthContextAdapter.ts | Updated PKP auth adapter to use SIGN_SESSION_KEY pricing instead of LIT_ACTION |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...tworks/src/networks/vNaga/shared/managers/pricing-manager/getMaxPricesForNodeProduct.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Anson <ansonox@gmail.com>
Ansonhkg
requested review from
DashKash54,
FedericoAmura,
MaximusHaximus,
glitch003 and
hwrdtm
hwrdtm
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
SIGN_SESSION_KEYproduct when pulling price feed data so we capture all four endpoint prices from the contractsgetMaxPricesForNodeProduct, extend the pricing schema forSIGN_SESSION_KEY, and prove the behaviour with a targeted unit testSIGN_SESSION_KEYpricing path while leaving the custom auth adapter onLIT_ACTION