-
Notifications
You must be signed in to change notification settings - Fork 87
feat: cherry-pick naga workflows #929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the existing Bun-based prerelease workflow with a new PNPM-based release workflow for the naga project. The release workflow is triggered by successful E2E test runs on naga branches and handles both version bumping and package publishing.
- Removes the manual prerelease snapshot workflow that required manual triggering on changeset release branches
- Adds automated release workflow that triggers after successful E2E tests on naga/canary-naga branches
- Switches from Bun to PNPM for package management and dependency installation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/release.yml | New automated release workflow with PNPM, Rust, and wasm-pack setup |
| .github/workflows/prerelease.yml | Removes existing Bun-based manual prerelease workflow |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| @@ -0,0 +1,117 @@ | |||
| name: Release | |||
| on: | |||
| workflow_run: | |||
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The workflow depends on a specific workflow name 'E2E - Naga (matrix)'. If this workflow doesn't exist or its name changes, this release workflow will never trigger. Consider verifying this workflow exists or adding a comment explaining the dependency.
| workflow_run: | |
| workflow_run: | |
| # NOTE: The following workflow name must match the name of the workflow that triggers this release. | |
| # If the workflow 'E2E - Naga (matrix)' is renamed, update this value accordingly. |
| version: 9.15.0 | ||
|
|
||
| - name: Install rust | ||
| uses: actions-rs/toolchain@v1 |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actions-rs/toolchain@v1 action is deprecated and no longer maintained. Consider using dtolnay/rust-toolchain or actions/setup-rust instead for better security and maintenance.
| uses: actions-rs/toolchain@v1 | |
| uses: dtolnay/rust-toolchain@v1 |
| - name: Install wasm-pack | ||
| uses: jetli/wasm-pack-action@v0.4.0 | ||
| with: | ||
| version: '0.12.1' |
Copilot
AI
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard-coded wasm-pack version '0.12.1' may become outdated. Consider using 'latest' or a more recent version, or document why this specific version is required.
| version: '0.12.1' | |
| version: 'latest' |
WHAT
Add release workflow from naga