fix(release.yml): set default branch for changesets action #936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a configuration issue in the GitHub Actions release workflow by explicitly setting the default branch for the changesets action. The change ensures the workflow uses the correct branch reference when GitHub executes the workflow from the default branch.
- Added explicit branch configuration for the changesets action with fallback logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| id: changesets | ||
| uses: changesets/action@v1 | ||
| with: | ||
| branch: ${{ github.event.workflow_run.head_branch || 'naga' }} |
There was a problem hiding this comment.
The hardcoded fallback branch 'naga' appears to be a magic value. Consider using a more descriptive name or making it configurable through repository variables/secrets to improve maintainability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
GitHub always executes the workflow file from the default branch (main)