fix(ci): release runs on branch tip; health-check uses js-sdk@naga; a… #940
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates CI workflows to improve release process reliability and health check configuration. The changes ensure the release workflow runs on the correct branch tip and configures the health check to use the js-sdk repository with the naga branch.
- Enhanced release workflow to fetch and verify the correct branch tip SHA
- Updated health check workflow to checkout from LIT-Protocol/js-sdk repository using naga branch
- Added debug output steps to both workflows for better troubleshooting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .github/workflows/release.yml | Added debug output and improved branch tip resolution with more robust git fetch |
| .github/workflows/naga-health-check.yml | Changed to checkout js-sdk repository on naga branch and added debug context |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| git fetch origin "$BRANCH" | ||
| echo "sha=$(git rev-parse \"origin/$BRANCH\")" >> "$GITHUB_OUTPUT" | ||
| git fetch --no-tags --prune --depth=1 origin "$BRANCH" | ||
| TIP_SHA=$(git rev-parse --verify "origin/$BRANCH^{commit}") |
There was a problem hiding this comment.
[nitpick] The ^{commit} suffix in git rev-parse --verify \"origin/$BRANCH^{commit}\" may be unnecessary since git rev-parse on a branch reference already resolves to the commit SHA. Consider simplifying to git rev-parse --verify \"origin/$BRANCH\" for better readability.
| TIP_SHA=$(git rev-parse --verify "origin/$BRANCH^{commit}") | |
| TIP_SHA=$(git rev-parse --verify "origin/$BRANCH") |
1 participant
WHAT