Skip to content

Conversation

@Ansonhkg
Copy link
Collaborator

@Ansonhkg Ansonhkg commented Oct 24, 2025

WHAT

  • include PubkeyRouter.getDerivedPubkey in the generated signatures and viem bindings
  • wire litClient.utils.getDerivedKeyId to call the PubkeyRouter contract with the staking address and default key set id

TEST

import { createLitClient } from '@lit-protocol/lit-client';
import { nagaTest } from '@lit-protocol/networks';
import { keccak256, stringToBytes } from 'viem';

const IPFS_CID = 'QmcA9npUnrzsmvx9sfmZDnEnPAEbMA5kp4tnkueYqiJKZv';
const EXPECTED_DERIVED_PUBKEY =
  '0x044e8f8e87e6192869a369b774fd9feba4607df95057eb58981626bd108f77d50674e587cc48c8a0a8c69ad650825ee1adf5f31acb4075e9327e625cd880a1dfdb';

describe('Derived Pubkey Ticket', () => {
  test('should derive pubkey', async () => {
    const derivedKeyId = keccak256(stringToBytes(`lit_action_${IPFS_CID}`));
    const litClient = await createLitClient({
      network: nagaTest,
    });
    const ctx = await litClient.utils.getDerivedKeyId(derivedKeyId);
    expect(ctx).toBe(EXPECTED_DERIVED_PUBKEY);
  });
});
image

Snapshot Releases

🦋  New tag:  @lit-protocol/auth-services@0.0.0-20251024015833
🦋  New tag:  @lit-protocol/constants@0.0.0-20251024015833
🦋  New tag:  @lit-protocol/contracts@0.0.0-20251024015833
🦋  New tag:  @lit-protocol/e2e@0.0.0-20251024015833
🦋  New tag:  @lit-protocol/lit-client@0.0.0-20251024015833
🦋  New tag:  @lit-protocol/networks@0.0.0-20251024015833

Copilot AI review requested due to automatic review settings October 24, 2025 01:41
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2025

CLA assistant check
All committers have signed the CLA.

@Ansonhkg Ansonhkg changed the base branch from master to naga October 24, 2025 01:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes a large number of test files from the local-tests directory, focusing on wrapped-keys tests and various PKP Ethers wallet signing tests. The purpose appears to be cleaning up the test suite by removing deprecated or obsolete test cases.

Reviewed Changes

Copilot reviewed 5 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Multiple testFail* files in wrapped-keys/ Removed negative test cases for wrapped key import scenarios with invalid/expired/max expiry session signatures
Multiple testEthereum* and testExport* files in wrapped-keys/ Removed test cases for Ethereum signing, message signing, and key export functionality with wrapped keys
Multiple testUse* files Removed test cases for session signature validation scenarios including PKP, EOA, and Lit Action session sigs
Multiple testPkpEthers* files Removed test cases for PKP Ethers wallet functionality across different signing methods and session sig types
testRelayer.ts, testSolAuthSig*, testShaEip1271* files Removed miscellaneous test cases for relayer functionality, Solana auth signatures, and EIP-1271 signatures

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@glitch003 glitch003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for helping out users in discord and noticing that we need this and making it happen so fast!! 🔥

@Ansonhkg Ansonhkg merged commit 2ccfde5 into naga Oct 24, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants