Work-around for ROCM overflowing ints when scan-summing arrays#1525
Merged
Work-around for ROCM overflowing ints when scan-summing arrays#1525
Conversation
Add notes about conditions for backing out the work-around.
publixsubfan
approved these changes
Mar 28, 2025
kennyweiss
approved these changes
Mar 31, 2025
Member
kennyweiss
left a comment
There was a problem hiding this comment.
Thanks @gunney1
Clearly, this is necessary.
Other than more memory, are there performance implications?
Member
|
Looks like you missed an initialization: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We have 2 arrays, one with booleans and one with ints in [0,5], but we have to use more bits to represent them for ROCM. We do sum scans on them and put the output in 32-bit ints. However, ROCM is doing the sum in the input type without promoting to the output type. This work-around bumps up the input type.
Related to llnl/RAJA#1631