-
Notifications
You must be signed in to change notification settings - Fork 65
Open
Description
These will eventually make it into BLT docs as recommendations, but to start our list:
- Provide detailed installed cmake config file that reflects the features that your project was configured with:
https://github.com/LLNL/conduit/blob/develop/src/config/ConduitConfig.cmake.in
- On import, use import relative paths when looking for features and setting up combined targets:
https://github.com/LLNL/conduit/blob/d495f3f820508070210d22e88a910f28dca212cd/src/config/conduit_setup_deps.cmake#L17
https://github.com/LLNL/conduit/blob/d495f3f820508070210d22e88a910f28dca212cd/src/config/conduit_setup_targets.cmake#L67
- On import, resolve any dependencies that have not been found. But default, use paths that reflect the TPLs that your install was configured against. Allow TPL dirs to be overridden in downstream projects via vars like
ZZZ_DIR. Even if you support a different case (zzz_DIRorZzz_DIRORzZz_dIr), also supportZZZ_DIRfor consistency across packages.
- When exporting targets, use a
-targetssuffix in the exported target name, such as:
if you use your project's base name, you can encounter problems:
Metadata
Metadata
Assignees
Labels
No labels