Bugfix/GitHub 502: Error: No spec file found at path#504
Merged
Conversation
- Fix bug introduced during merge of stage refactor.
- install prefix was not created before build_environment.fork()
- build_environment.fork() calls setup_dependent_environment
- python's setup_dependent_environment can inadvertently create
the install prefix before directory_layout expects it.
- Clean up Package.do_install:
- simplify control flow: parent process now entirely responsible for
creating/destroying the install prefix. cleanup is now in one place.
- Hoisting cleanup out of the child improves nesting of try/catch in
`real_work`.
- `real_work` renamed to `build_process`
Member
Author
Member
Member
Member
Author
|
Thanks! |
tgamblin
added a commit
that referenced
this pull request
Mar 8, 2016
Bugfix/GitHub 502: Error: No spec file found at path
climbfuji
added a commit
to climbfuji/spack
that referenced
this pull request
Jan 24, 2025
…stack_dev Fix ectrans: instead of declaring a conflict with Intel LLVM compilers, apply patch from upstream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #502.
the install prefix before directory_layout expects it.
creating/destroying the install prefix. cleanup is now in one place.
real_work.real_workrenamed tobuild_processpangoinstall.