Adopt FileLike for more pipeline APIs #7134
Open
+705
−733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 20, 2025
| { | ||
| var parsedPath = org.labkey.api.util.Path.parse(relativePath); | ||
|
|
||
| if (ROOT_BASE.cloud.equals(_defaultRoot)) |
There was a problem hiding this comment.
If this method now works for Cloud, then resolveToNioPath() should probably be rewritten to just call this method. Might be worth a comment that that this means that when the primary root is S3 it does not support secondary pipeline root. Hopefully, that's reflected in our docs to (and configuration page. This is A-OK by me, I really dislike the secondary roots.
There was a problem hiding this comment.
I'll add a metric to see who has secondary/supplemental directories. The use case that added them was for a customer who has long since abandoned their deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
FileLike helps us do better validation of file paths. We can use it instead of File or Path in places like where the user selects files to take a pipeline action.
Changes
FileLikeTasks 📍