Replace data row ids with global keys #1006
Conversation
ovalle15
commented
Mar 17, 2023
ovalle15
commented
- Replace data row ids with global keys
- Replace create_data_row with create_data_rows
- Added task methods for failed data rows
- Updated text explanations
- Added data class for creating labels
- Added new supported annotations (NER annotation type for pdf)
- Added newly supported relationship annotation to image notebook
- Refactor video notebook to include annotation types
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
| { | ||
| "metadata": {}, | ||
| "source": [ | ||
| "!pip install -q 'labelbox[data]'" |
There was a problem hiding this comment.
Line #6. global_keys=global_key, # Paginated collection of data row objects, list of data row ids or global keys
global_keys=[global_key]
Reply via ReviewNB
| ], | ||
| "cell_type": "markdown" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Line #3. global_keys=global_key, # DataRow objects, a list of global keys or data row ids are supported
global_keys=[global_key]
Reply via ReviewNB
| ], | ||
| "cell_type": "markdown" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Line #1. label_ndjson_method2 = []
Should we rename this to just label_ndjson or annotations_ndjson ?
Reply via ReviewNB
| ], | ||
| "cell_type": "markdown" | ||
| }, | ||
| { |
There was a problem hiding this comment.
Line #3. global_keys=global_key, # A list of data rows or data row ids
global_keys=[global_key]
Reply via ReviewNB
| "cell_type": "markdown" | ||
| }, | ||
| { | ||
| "metadata": {}, |
There was a problem hiding this comment.
Line #6. global_keys=global_key, # A list of data rows or data row ids
global_keys=[global_key]
Reply via ReviewNB
| { | ||
| "metadata": {}, | ||
| "source": [ | ||
| "!pip install -q 'labelbox[data]'" |
There was a problem hiding this comment.
Line #1. model_run.upsert_data_rows(global_keys=global_key)
global_keys=[global_key]
Reply via ReviewNB
| { | ||
| "metadata": {}, | ||
| "source": [ | ||
| "!pip install -q 'labelbox[data]'" |
There was a problem hiding this comment.
| { | ||
| "metadata": {}, | ||
| "source": [ | ||
| "!pip install -q 'labelbox[data]'" |
There was a problem hiding this comment.
Line #1. model_run.upsert_data_rows(global_keys=global_key)
Might be better practice to pass in a list of global_keys here, since the function accepts a list
model_run.upsert_data_rows(global_keys=[global_key])
Reply via ReviewNB
| { | ||
| "metadata": {}, | ||
| "source": [ | ||
| "!pip install -q 'labelbox[data]'" |
There was a problem hiding this comment.
Same comment as before, let's pass in a list of global_keys by wrapping global_key in a list: [global_key] .
Also, we should update the comment next to it
Reply via ReviewNB
| { | ||
| "metadata": {}, | ||
| "source": [ | ||
| "!pip install -q 'labelbox[data]'" |
There was a problem hiding this comment.
Line #2. set_feature_schema_id(features_schema, bbox_with_radio_subclass_annotation_ndjson)
Do we need these steps, if we can reference the feature schemas by name?
Reply via ReviewNB
There was a problem hiding this comment.
I have not been able to do this by name - We discussed at some point but I don't think we investigated further.
| " \"first-batch-convo-demo\", # Each batch in a project must have a unique name\n", | ||
| " [data_row.uid], # Paginated collection of data row objects\n", | ||
| " 5 # priority between 1(Highest) - 5(lowest)\n", | ||
| " global_keys=global_key, # Paginated collection of data row objects, list of data row ids or global keys\n", |
There was a problem hiding this comment.
I think this one might need the array wrapping update too [global_key]
| " \"first-batch-text-demo\", # Each batch in a project must have a unique name\n", | ||
| " dataset.export_data_rows(), # A list of data rows or data row ids\n", | ||
| " 5 # priority between 1(Highest) - 5(lowest)\n", | ||
| " global_keys=global_key, # A list of data rows or data row ids\n", |
There was a problem hiding this comment.
just noting this spot too
