[AL-5686] Remove ndjson library and replaced it with a custom ndjson parser #1092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
force-pushed
the
VB/replace-ndjson
branch
5 times, most recently
from
e821dfe to
7dabe51
Compare
added 9 commits
May 12, 2023 13:33
Replace ndjson.loads with parser.loads
…d Python json decoder To be able to handle loading byte, bytearray etc. all other types as support by the json library itself
…on of mypy we are using
Also add dump() to the parser, used in tests only
vbrodsky
force-pushed
the
VB/replace-ndjson
branch
from
7dabe51 to
c366c6b
Compare
whistler
approved these changes
May 15, 2023
Contributor
whistler
left a comment
whistler
left a comment
There was a problem hiding this comment.
Looks like an elegant solution!
yamini-labelbox
approved these changes
May 15, 2023
Contributor
yamini-labelbox
left a comment
yamini-labelbox
left a comment
There was a problem hiding this comment.
LGTM! Super clean! Ship it after MLSE approves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story: https://labelbox.atlassian.net/browse/AL-5686
Even though this is a large PR, 90% of files is just a drop-in replacement of the 3d party ndjson library with our own. The rest 10% are important updates to the parser library to address issues from integration tests and removal of the 3d party ndjson library from our setup and requirements.txt
List of Affected SDK API's