Skip to content

[X-0] Improve exports error handling #1160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[X-0] Improve exports error handling #1160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions labelbox/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,8 @@ def execute(self,
data=None,
files=None,
timeout=60.0,
experimental=False):
experimental=False,
error_log_key="message"):
""" Sends a request to the server for the execution of the
given query.

Expand Down Expand Up @@ -267,7 +268,7 @@ def get_error_status_code(error):
"extensions", "code")
if malformed_request_error is not None:
raise labelbox.exceptions.MalformedQueryException(
malformed_request_error["message"])
malformed_request_error[error_log_key])

# A lot of different error situations are now labeled serverside
# as INTERNAL_SERVER_ERROR, when they are actually client errors.
Expand Down
7 changes: 3 additions & 4 deletions labelbox/schema/data_row.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,9 @@ def export_v2(client: 'Client',
}
}

res = client.execute(
create_task_query_str,
query_params,
)
res = client.execute(create_task_query_str,
query_params,
error_log_key="errors")
print(res)
res = res[mutation_name]
task_id = res["taskId"]
Expand Down
7 changes: 3 additions & 4 deletions labelbox/schema/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,10 +632,9 @@ def export_v2(self,
})
query_params["input"]["filters"]["searchQuery"]["query"] = search_query

res = self.client.execute(
create_task_query_str,
query_params,
)
res = self.client.execute(create_task_query_str,
query_params,
error_log_key="errors")
res = res[mutation_name]
task_id = res["taskId"]
user: User = self.client.get_user()
Expand Down
7 changes: 3 additions & 4 deletions labelbox/schema/model_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,10 +536,9 @@ def export_v2(self,
},
}
}
res = self.client.execute(
create_task_query_str,
queryParams,
)
res = self.client.execute(create_task_query_str,
queryParams,
error_log_key="errors")
res = res[mutation_name]
task_id = res["taskId"]
user: User = self.client.get_user()
Expand Down
7 changes: 3 additions & 4 deletions labelbox/schema/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,10 +486,9 @@ def export_v2(self,
search_query = build_filters(self.client, _filters)
query_params["input"]["filters"]["searchQuery"]["query"] = search_query

res = self.client.execute(
create_task_query_str,
query_params,
)
res = self.client.execute(create_task_query_str,
query_params,
error_log_key="errors")
res = res[mutation_name]
task_id = res["taskId"]
user: User = self.client.get_user()
Expand Down
7 changes: 3 additions & 4 deletions labelbox/schema/slice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,9 @@ def export_v2(self,
}
}

res = self.client.execute(
create_task_query_str,
query_params,
)
res = self.client.execute(create_task_query_str,
query_params,
error_log_key="errors")
res = res[mutation_name]
task_id = res["taskId"]
user: User = self.client.get_user()
Expand Down