Skip to content

[AL-6732] fix test by adding sleep #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2023
Merged

[AL-6732] fix test by adding sleep #1178

merged 1 commit into from
Jul 31, 2023

Conversation

@attila-papai
Copy link
Contributor

@attila-papai attila-papai commented Jul 28, 2023 •
edited
Loading

We need a little sleep between these two calls for ES syncing

batch = project.create_batch("batch test", data_rows)
result = list(batch.export_data_rows())

Fixes test case tests/integration/test_batch.py::test_export_data_rows for ADV

tomislav-peharda
tomislav-peharda approved these changes Jul 29, 2023
View reviewed changes
Copy link
Contributor

@tomislav-peharda tomislav-peharda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope 5 s will be sufficient

@attila-papai attila-papai merged commit b2749c4 into develop Jul 31, 2023
@attila-papai attila-papai deleted the attila/AL-6732-test-fix-sleep branch July 31, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbrodsky vbrodsky Awaiting requested review from vbrodsky

1 more reviewer

@tomislav-peharda tomislav-peharda tomislav-peharda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@attila-papai @tomislav-peharda