Skip to content

wait until DRs are processed before adding them to a model run #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

wait until DRs are processed before adding them to a model run #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions tests/integration/annotation_import/test_mea_prediction_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def test_create_from_objects_with_confidence(predictions_with_confidence,
annotation_import_test_helpers.assert_file_content(
annotation_import.input_file_url, predictions_with_confidence)
annotation_import.wait_until_done()
assert annotation_import.state == AnnotationImportState.FINISHED
annotation_import_test_helpers.download_and_assert_status(
annotation_import.status_file_url)

Expand Down
10 changes: 7 additions & 3 deletions tests/integration/annotation_import/test_model_run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,12 @@ def test_model_run_data_rows_delete(model_run_with_data_rows):
assert len(before) == len(after) + 1


def test_model_run_upsert_data_rows(dataset, model_run):
def test_model_run_upsert_data_rows(dataset, model_run, configured_project):
n_model_run_data_rows = len(list(model_run.model_run_data_rows()))
assert n_model_run_data_rows == 0
data_row = dataset.create_data_row(row_data="test row data")
configured_project._wait_until_data_rows_are_processed(
data_row_ids=[data_row.uid])
model_run.upsert_data_rows([data_row.uid])
n_model_run_data_rows = len(list(model_run.model_run_data_rows()))
assert n_model_run_data_rows == 1
Expand Down Expand Up @@ -166,13 +168,15 @@ def get_model_run_status():


def test_model_run_split_assignment_by_data_row_ids(model_run, dataset,
image_url):
image_url,
configured_project):
n_data_rows = 10
data_rows = dataset.create_data_rows([{
"row_data": image_url
} for _ in range(n_data_rows)])
data_row_ids = [data_row['id'] for data_row in data_rows.result]

configured_project._wait_until_data_rows_are_processed(
data_row_ids=data_row_ids)
model_run.upsert_data_rows(data_row_ids)

with pytest.raises(ValueError):
Expand Down