Skip to content

DEVOPS-1626 - Fix bad workflow options #1229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2023
Merged

DEVOPS-1626 - Fix bad workflow options #1229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aeb6bdb
DEVOPS-1626 - Fix bad workflow options
lhriley Sep 1, 2023
4609118
DEVOPS-1626 - container names must be lowercase
lhriley Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions .github/workflows/release-container.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@ on:
release:
types: [published]

env:
CONTAINER_IMAGE: "ghcr.io/${{ github.repository }}"

jobs:
context:
runs-on: ubuntu-latest
Expand All @@ -15,6 +18,10 @@ jobs:
packages: write

steps:
- name: downcase CONTAINER_IMAGE
run: |
echo "CONTAINER_IMAGE=${CONTAINER_IMAGE,,}" >> ${GITHUB_ENV}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

Expand All @@ -31,14 +38,10 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
push: true

registry: ghcr.io
organization: "${{ github.event.repository.owner.login }}"
repository: "${{ github.event.repository.name }}"

platforms: |
linux/amd64
linux/arm64

tags: |
latest
${{ github.event.release.tag_name }}
${{ env.CONTAINER_IMAGE }}:latest
${{ env.CONTAINER_IMAGE }}:${{ github.event.release.tag_name }}
15 changes: 9 additions & 6 deletions .github/workflows/testing-container.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ on:
branches:
- 'develop'

env:
CONTAINER_IMAGE: "ghcr.io/${{ github.repository }}"

jobs:
context:
runs-on: ubuntu-latest
Expand All @@ -16,6 +19,10 @@ jobs:
packages: write

steps:
- name: downcase CONTAINER_IMAGE
run: |
echo "CONTAINER_IMAGE=${CONTAINER_IMAGE,,}" >> ${GITHUB_ENV}

- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2

Expand All @@ -32,14 +39,10 @@ jobs:
github-token: ${{ secrets.GITHUB_TOKEN }}
push: true

registry: ghcr.io
organization: "${{ github.event.repository.owner.login }}"
repository: "${{ github.event.repository.name }}"

platforms: |
linux/amd64
linux/arm64

tags: |
develop
${{ github.sha }}
${{ env.CONTAINER_IMAGE }}:develop
${{ env.CONTAINER_IMAGE }}:${{ github.sha }}