Skip to content

Add 3.10 to gihub PR tests #1233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2023
Merged

Add 3.10 to gihub PR tests #1233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
48f3c26
Add 3.10 to gihub PR tests
Sep 6, 2023
57da848
Address test issues
Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/python-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,10 @@ jobs:
prod-key: PROD_LABELBOX_API_KEY_3
staging-key: STAGING_LABELBOX_API_KEY_3
da-test-key: DA_GCP_LABELBOX_API_KEY
- python-version: '3.10'
prod-key: PROD_LABELBOX_API_KEY_4
staging-key: STAGING_LABELBOX_API_KEY_4
da-test-key: DA_GCP_LABELBOX_API_KEY
Comment on lines +29 to +32
Copy link
Contributor

@mnoszczak mnoszczak Sep 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only STAGING_LABELBOX_API_KEY_4 is required, right? LGTM


steps:
- name: Cancel previous workflow
Expand Down
8 changes: 6 additions & 2 deletions tests/integration/annotation_import/test_ndjson_validation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from labelbox.schema.media_type import MediaType
import pytest

from labelbox import parser
Expand Down Expand Up @@ -25,8 +26,11 @@ def get_data_row_id(indx=0):

@pytest.fixture(scope="module", autouse=True)
def configured_project_with_ontology(client, ontology, rand_gen):
project = client.create_project(name=rand_gen(str),
queue_mode=QueueMode.Batch)
project = client.create_project(
name=rand_gen(str),
queue_mode=QueueMode.Batch,
media_type=MediaType.Image,
)
editor = list(
client.get_labeling_frontends(
where=LabelingFrontend.name == "editor"))[0]
Expand Down
4 changes: 3 additions & 1 deletion tests/integration/test_data_rows.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import uuid
from datetime import datetime
import json
from labelbox.schema.media_type import MediaType

import pytest
import requests
Expand Down Expand Up @@ -959,7 +960,8 @@ def test_data_row_bulk_creation_sync_with_same_global_keys(
def test_create_conversational_text(dataset, conversational_content):
examples = [
{
**conversational_content, 'media_type': 'CONVERSATIONAL'
**conversational_content, 'media_type':
MediaType.Conversational.value
},
conversational_content,
{
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# content of: tox.ini , put in same dir as setup.py
[tox]
envlist = py37, py38, py39
envlist = py37, py38, py39, py310

[testenv]
# install pytest in the virtualenv where commands will be executed
Expand Down