Skip to content

Conversation

@vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Oct 5, 2023

Story: https://labelbox.atlassian.net/browse/SDK-302

The backoff library we use is old and it conflicts with the version the lightning-ai library used by Ancestry

Upon further inspection, I have discovered this library can be replaced with google.api_core.retry we use elsewhere in our code

This will execute exponential backoff for 2 minutes (default), like

tests/integration/annotation_import/test_bulk_import_request.py::test_wait_till_done 
Refreshing... at datetime:  18:57:24
Refreshing... at datetime:  18:57:26
Refreshing... at datetime:  18:57:29
Refreshing... at datetime:  18:57:32
Refreshing... at datetime:  18:57:44
Refreshing... at datetime:  18:58:05
...

@vbrodsky vbrodsky force-pushed the VB/upgrade-backoff_SDK-302 branch from 0c0b91f to c6ae9b3 Compare October 5, 2023 19:18
@vbrodsky vbrodsky changed the title [SDK=302] Remove backoff library [SDK-302] Remove backoff library Oct 6, 2023
@vbrodsky vbrodsky merged commit 7f2c6c6 into develop Oct 6, 2023
@vbrodsky vbrodsky deleted the VB/upgrade-backoff_SDK-302 branch October 6, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants