[SDK-427] Add unit-tests for ExportTask #1289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbrodsky
approved these changes
Nov 20, 2023
Contributor
vbrodsky
left a comment
vbrodsky
left a comment
There was a problem hiding this comment.
with some suggestions
PS Are you also planning to add sdk integration test?
|
|
||
|
|
||
| @pytest.fixture | ||
| def generate_random_ndjson(rand_gen): |
Contributor
There was a problem hiding this comment.
why not use static json line for test predictability?
| def test_with_correct_ndjson(self, tmp_path, generate_random_ndjson): | ||
| directory = tmp_path / "file-converter" | ||
| directory.mkdir() | ||
| line_count = 10 |
Contributor
There was a problem hiding this comment.
curious why can't we test the same with 2 lines
| ndjson = generate_random_ndjson(line_count) | ||
| file_content = "\n".join(ndjson) + "\n" | ||
|
|
||
| mock_client = MagicMock() |
kopreschko
force-pushed
the
kopreschko/SDK-427
branch
from
38388a7 to
b175f81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.