Skip to content

Vb/fix sdk failures #1338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 18, 2023
Merged

Vb/fix sdk failures #1338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eacf99
Update video expected data due to fix for segments export
Dec 18, 2023
3f6a9b9
Fix create batch negative tests due to change in batch priority rules
Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion tests/integration/annotation_import/fixtures/export_v2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,9 @@ def expected_export_v2_text():
def expected_export_v2_video():
expected_annotations = {
'frames': {},
'segments': {},
'segments': {
'<cuid>': [[7, 13], [18, 19]]
},
'key_frame_feature_map': {},
'classifications': [{
'name': 'checklist',
Expand Down
27 changes: 3 additions & 24 deletions tests/integration/test_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,43 +65,22 @@ def test_create_batch_with_non_existent_global_keys(project: Project):
) == "Data rows with the following global keys do not exist: key1."


def test_create_batch_with_negative_priority(project: Project,
small_dataset: Dataset):
def test_create_batch_with_string_priority(project: Project,
small_dataset: Dataset):
with pytest.raises(LabelboxError):
project.create_batch("batch1",
data_rows=get_data_row_ids(small_dataset),
priority=-1)
priority="abcd")


def test_create_batch_with_null_priority(project: Project,
small_dataset: Dataset):
with pytest.raises(LabelboxError):
project.create_batch("batch1",
data_rows=get_data_row_ids(small_dataset),
priority=0)

with pytest.raises(LabelboxError):
project.create_batch("batch1",
data_rows=get_data_row_ids(small_dataset),
priority=None)


def test_create_batch_with_out_of_bound_priority(project: Project,
small_dataset: Dataset):
with pytest.raises(LabelboxError):
project.create_batch("batch1",
data_rows=get_data_row_ids(small_dataset),
priority=6)


def test_create_batch_with_float_number_priority(project: Project,
small_dataset: Dataset):
with pytest.raises(LabelboxError):
project.create_batch("batch1",
data_rows=get_data_row_ids(small_dataset),
priority=4.9)


def test_create_batch_async(project: Project,
big_dataset_data_row_ids: List[str]):
batch = project._create_batch_async("big-batch",
Expand Down