Skip to content

Conversation

@vbrodsky
Copy link
Contributor

@vbrodsky vbrodsky commented Dec 19, 2023

Story: https://labelbox.atlassian.net/browse/SDK-415
API PR: https://github.com/Labelbox/intelligence/pull/18615

  1. Updated DataRowMetadataOntology bulk_export to support global keys as Identifiables
  2. Updated the Identifiables to support index access and slicing as required by this sdk method

@vbrodsky vbrodsky requested review from a team, kopreschko and sqlboy December 19, 2023 21:46
@vbrodsky vbrodsky force-pushed the VB/bulk-export-metadata-by-gk_SDK-415 branch from 93244fa to aaa0b74 Compare December 19, 2023 21:52
@vbrodsky vbrodsky force-pushed the VB/bulk-export-metadata-by-gk_SDK-415 branch from cf30da0 to 3c09f4c Compare December 20, 2023 18:23
query, {
"dataRowIdentifiers": {
"ids": [id for id in _data_row_ids],
"idType": _data_row_ids._id_type
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make a getter for _id_type so we're not accessing a 'private' var here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes ok I was thinking about it too, good comment

Copy link
Contributor

@yamini-labelbox yamini-labelbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vbrodsky vbrodsky force-pushed the VB/bulk-export-metadata-by-gk_SDK-415 branch from 4a0388e to 0da9028 Compare December 21, 2023 22:36
@vbrodsky vbrodsky merged commit 7eda10d into develop Dec 21, 2023
@vbrodsky vbrodsky deleted the VB/bulk-export-metadata-by-gk_SDK-415 branch December 21, 2023 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants