[PLT-130] Validate "external_id", "global_key", "row_data" fields in row update #1439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfendell-labelbox
force-pushed
the
PLT-130
branch
from
535dd41 to
6b7dcd7
Compare
sfendell-labelbox
changed the title
mrobers1982
reviewed
Feb 28, 2024
sfendell-labelbox
force-pushed
the
PLT-130
branch
3 times, most recently
from
d954484 to
1db9bb1
Compare
mrobers1982
reviewed
Feb 29, 2024
labelbox/schema/data_row.py
Outdated
| # Convert row data to string if it is an object | ||
| # All other updates pass through | ||
| row_data = kwargs.get("row_data") | ||
| if not row_data and not kwargs.get("external_id") and not kwargs.get( |
Contributor
There was a problem hiding this comment.
I do not think you implemented the logic I mentioned here - #1439 (comment).
What happens if row_data is set to a non-empty value and global_key is set to an empty value?
You might need to differentiate a field being unset from it being set but to an empty value.
sfendell-labelbox
force-pushed
the
PLT-130
branch
3 times, most recently
from
dce1843 to
42f452c
Compare
sfendell-labelbox
changed the title
sfendell-labelbox
changed the title
sfendell-labelbox
force-pushed
the
PLT-130
branch
from
42f452c to
62773d5
Compare
mrobers1982
approved these changes
Feb 29, 2024
sfendell-labelbox
force-pushed
the
PLT-130
branch
from
62773d5 to
3e4b653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of these fields should be set to an empty value, and at least 1 is needed for an update.