[PLT-383] Fix SDK integration tests. #1508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfendell-labelbox
force-pushed
the
debug-PLT-383
branch
from
aebfbdd to
8211b82
Compare
adrian-chang
approved these changes
Mar 26, 2024
midhun-pm
approved these changes
Mar 26, 2024
sfendell-labelbox
force-pushed
the
debug-PLT-383
branch
3 times, most recently
from
256aa15 to
cbbf04f
Compare
sfendell-labelbox
force-pushed
the
debug-PLT-383
branch
from
cbbf04f to
a5a869a
Compare
Contributor
Author
|
Video and text tests are failing locally but succeeding on staging...Not sure what's going on there, but I know it's unrelated to my exporter change so I'm just getting rid of that. Removing the dependency on export ordering is still necessary though |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Video and text tests are failing because expected values do not match existing output, so I fixed those expected values.
test_import_data_types_v2 relies on ordering of exported data, which exporter makes no promises about. This fix is required to merge https://github.com/Labelbox/python-monorepo/pull/1789.