Skip to content

[PLT-0] reenable tests #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2024
Merged

[PLT-0] reenable tests #1519

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
136f586
reenable tests
Mar 29, 2024
d29fc12
reenable tests
Mar 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions tests/integration/test_foundry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,6 @@ def test_get_app_with_invalid_id(foundry_client):
foundry_client._get_app("invalid-id")


@pytest.mark.skip(reason="broken")
def test_run_foundry_app_with_data_row_id(foundry_client, data_row, app,
random_str):
data_rows = lb.DataRowIds([data_row.uid])
Expand All @@ -104,7 +103,6 @@ def test_run_foundry_app_with_data_row_id(foundry_client, data_row, app,
assert task.status == 'COMPLETE'


@pytest.mark.skip(reason="broken")
def test_run_foundry_app_with_global_key(foundry_client, data_row, app,
random_str):
data_rows = lb.GlobalKeys([data_row.global_key])
Expand All @@ -116,7 +114,6 @@ def test_run_foundry_app_with_global_key(foundry_client, data_row, app,
assert task.status == 'COMPLETE'


@pytest.mark.skip(reason="broken")
def test_run_foundry_app_returns_model_run_id(foundry_client, data_row, app,
random_str):
data_rows = lb.GlobalKeys([data_row.global_key])
Expand All @@ -129,7 +126,6 @@ def test_run_foundry_app_returns_model_run_id(foundry_client, data_row, app,
assert model_run.uid == model_run_id


@pytest.mark.skip(reason="broken")
def test_run_foundry_with_invalid_data_row_id(foundry_client, app, random_str):
invalid_datarow_id = 'invalid-global-key'
data_rows = lb.GlobalKeys([invalid_datarow_id])
Expand All @@ -141,7 +137,6 @@ def test_run_foundry_with_invalid_data_row_id(foundry_client, app, random_str):
assert invalid_datarow_id in exception.value


@pytest.mark.skip(reason="broken")
def test_run_foundry_with_invalid_global_key(foundry_client, app, random_str):
invalid_global_key = 'invalid-global-key'
data_rows = lb.GlobalKeys([invalid_global_key])
Expand All @@ -150,4 +145,4 @@ def test_run_foundry_with_invalid_global_key(foundry_client, app, random_str):
model_run_name=f"test-app-with-invalid-global-key-{random_str}",
data_rows=data_rows,
app_id=app.id)
assert invalid_global_key in exception.value
assert invalid_global_key in exception.value