Skip to content

Conversation

@sfendell-labelbox
Copy link
Contributor

@sfendell-labelbox sfendell-labelbox commented Apr 2, 2024

Leaving error url empty is confusing to users. Since we already print errors to the results file (and can't remove this behavior without breaking backwards compatibility), it can be reused for errors.

@sfendell-labelbox sfendell-labelbox requested a review from a team as a code owner April 2, 2024 23:49
@sfendell-labelbox sfendell-labelbox changed the title [PLT-51] Add error url for import test. [PLT-51] Add error url for import and upsert task. Apr 2, 2024
Copy link
Contributor

@vbrodsky vbrodsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff

@sfendell-labelbox sfendell-labelbox merged commit 8b42d2b into develop Apr 3, 2024
@sfendell-labelbox sfendell-labelbox deleted the PLT-51 branch April 3, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants